Skip to content

migrator: tolerate context.Canceled in consumer group test stream goroutine#4302

Open
mmatczuk wants to merge 1 commit intomainfrom
mmt/migrator-fixes-v2
Open

migrator: tolerate context.Canceled in consumer group test stream goroutine#4302
mmatczuk wants to merge 1 commit intomainfrom
mmt/migrator-fixes-v2

Conversation

@mmatczuk
Copy link
Copy Markdown
Contributor

@mmatczuk mmatczuk commented Apr 20, 2026

Commits

  • tolerate context.Canceled in consumer group test stream goroutine

Jira

  • CON-446

@claude
Copy link
Copy Markdown

claude Bot commented Apr 20, 2026

Commits
LGTM

Review
Single-file change that replaces require.NoError(t, stream.Run(ctx)) with the documented pattern of tolerating context.Canceled and using t.Errorf from a background goroutine. Matches the async-operations guidance in the project test patterns (see integration_test.go#L420-L426).

LGTM

This was referenced Apr 20, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mmatczuk